Put the latest build in as well.
I've now touched base with all classes except DK and Lock since our initial release. I'm sure there are bugs with the fixes and other bugs that haven't been reported yet. But, we've got more things working than not now..by a very large majority. Each of the classes that have been looked at are now down to a handful of problems (or less) each. It's a good thing.
[ view entry ] ( 27 views ) | permalink
*Periodic Effects: Reduce in amount over time
-Figured out that periodic heals were getting the math from Wild Growth's calculations inadvertently. This should fix all periodic heals including the 'Lifebloom of Death' problem.
-- Hunter: --
*Focus Fire - is still not increasing ranged haste when used.
-Aura check had wrong ID number
*Embrace of the Shale Spider - Currently only increasing Stamina, and only increasing resistances by 1 per school
-Added formula for calculations and add all (except spirit) on the mod stat.
*Wolverine Bite - currently does 1 point of damage each time it is used by the pet.
-Added RAP coefficient
-- Druid: --
*Swipe (Bear Form) and Thrash - Still currently making a sound but doing nothing.
-Works fine at close range (1yrd). Was missing Effect Radius. I loaded the proper radius and tested it on the test server. Working to spec now or will in the next build.
-- Rogue: --
*Honor Among Thieves - Added to party member's target not rogue's target (Changed in 4.0.x hotfix)
-Added hotfix changes to use the rogue's current selected target (if the rogue is not friendly to target, of course). This is your SELECTED target not your combat target and that's what I read it should be. So, pay attention to what you're doing.
-- Warrior: --
*Sword and Board - Currently not resetting Shield Slam's cooldown when it procs
-Had old data from WotLK. Updated it and added a secondary check at end cast.
*Heroic Fury - Doesn't remove roots just applies immunity.
-Added removal flag.
*Berserker Rage - Doesn't allow cast during sap nor remove sap.
-Added removal flag and sap check bypass.
*Improved Hamstring - Not checking if previous Hamstring is yours nor is it applying a cooldown
-Added caster check and cooldown.
-- Paladin: --
*Zealotry should not consume Holy Power, but currently does.
-Disabled holy power consumption.
-- Mage: --
*Flame Orbs and Frostfire Orbs don't appear to be moving
-Neither had scripts..added them and cleaned up the scripts a bit..added Fire Power and Frostfire ranks..etc.
*Improved Freeze - Currently not proccing 2 stacks of Fingers of Frost when Summoned Water Elemental uses its Freeze ability on an enemy
-Added proc on freeze cast with talent
*Reactive Barrier - Currently not proccing Ice Barrier when the Mage is brought to or below 50% health
-Well, it's not 'to or below'..it's 'below 50%'. Set the proc as such and added the proper trigger spell.
*Glyph of Molten Armor - Currently not increasing Molten Armor's critical strike chance bonus
*Fingers of Frost - Currently causing all damaging spells to treat their targets as if they were frozen instead of just Ice Lance and Deep Freeze
-Added affected by check for Deep Freeze and Ice Lance with Fingers of Frost
*Improved Arcane Missiles - Currently not increasing the number of Arcane Missiles fired
-Spell is just set to increase channel time of Arcane Missile, I added that effect (750ms - Rank 1 and 1500ms Rank 2)
*Improved Cone of Cold is currently freezing the caster and not the target.
-Not sure why it would do that since the spell has a hostile flag and a range. Changed the victim to be the caster and target both then set the original caster flag to the caster. Should fix the problem if that was indeed what was wrong.
*Conjured Mana Cake - Currently not restoring Mana
-Added periodic dummy aura tick (second type on listing) to energize periodically as per spell dbc. This is a wide-range fix for all periodic dummy tick 'drink' spells.
[ view entry ] ( 8 views ) | permalink
I don't quite remember which issues I fixed but it was all the ones that were reported after the restart on the tracker. I was too busy with my head stuck in the code figuring out the crash problems that I forgot to copy the reports over.
[ view entry ] ( 3 views ) | permalink
-- Mage: --
*Pyromaniac - Currently not increasing Spell Haste when 3 or more targets are afflicted with Fire damage-over-time effects
-Added new periodic apply counting system and added trigger/calcs for Pyro
*Invisibility - The "Invisibility Veil" screen effect is currently persisting until logout
-Not quite sure if I nailed this down or not. The byte flag that sets this visual effect appears to have been applying but not removing under some circumstances. Attempted to fix the removal portion.
*Permafrost - not allowing the Water Elemental to be healed by any spell damage dealt by its owner
-Added effect to dealdamage on spells
*Frostbolt has NO slowing effect at this time.
-Umm..frostbolt applies a direct speed decrease aura. Are no other speed decrease auras working? Pretty sure it's something else not Frostbolt itself.
*Hot Streak and Improved Hot Streak - Currently causing Pyroblast to disappear off the hotbar
-This is that same core issue with not being able to replace effects on the spellbar client-side. It will trigger the freebie Pyroblast! immediately instead of setting it up to be used. Will have to suffice for now.
-- Paladin: --
"Hammer of Wrath" seems to be bugged. The spell procs, EVERYTIME I cast any other spell. Spams your screen with the proc every second.
-After not understanding what this report meant in the slightest, Collateral helped me figure out wtf was meant and what was going on. Pretty sure this will work to spec now.
-- Rogue: --
*Sanguinary Vein - Currently not preventing Rupture ticks from breaking Gouge
-Added system for checking removal on damage effects..included Gouge into the set.
-- Shaman: --
*Hex is breaking on all damage, it should allow some damage to be done before breaking.
-Same system as used for rogue. This one is a set 25% chance that it will break on damage instead of based on a rank like the rogue one. May need to change this percentage..depends on how it goes.
-- Priest: --
*Holy Fire - Invalid coefficient
-It had no coefficient set at all so I set it to 0.75 on DD and 0.25 on DoT. Until I find actual data, I can't set this to anything else.
*Mind Melt - does not increase shadow word: death's damage by 15/30% on targets below 25% health.
*Shadow Word: Death - does not do 3x damage on targets below 25%
*Atonement - Healing a random target in the raid, instead of a low hp target within 15 yards.
-Someone found actual data for this spell showing that it is lowest target. So, now it is coded to lowest target. Thanks.
*Mind Spike - when stacked to 3 on an enemy target, it doesn't increase our next mind blast's critical strike chance by 90%
-Implemented new aura type 308 (The proc spell on this uses it)
*Mind Spike - Does not remove periodic shadow effects at cast
-Added removal code at calc.
[ view entry ] ( 50 views ) | permalink
-- Rogue: --
*Honor Among Thieves - Currently not allowing critical strikes from raid or party members to generate a combo point on the Rogue's target
-Added the dummy aura proc to system. According to net sources, this wipes your current combo target and sets points on whatever your raid party member was attacking. So, that's how I set it...seems more annoying than functional but whatever. Would take all of 5secs to use your target instead.
*Precision - Currently not granting additional hit chance
-This is a standard aura mod. Not anything to 'fix' with it. I'd need more information about why people think this isn't working because no % hit mods at all in the game would work if this aura specifically didn't. It could be the requirements listed on it but I'd need more testing.
*Glyph of Hemorrhage - Currently dealing a flat 5 damage per tick instead of a percentage of the strike's damage over time. the Bleed produced by this glyph currently doesn't allow the Rogue to benefit from Sanguinary Vein
-Added Bleed mechanic mask to spellinfo and calculations into the proc. Strange that it's doing 5 damage..since it's base 3.
-- Haste: --
So, I found an obfuscated call to periodic/aura duration hidden in a completely retarded part of the core. Seems like that was what was causing casting speed auras to screw up my haste removal on channel/periodic effects. I may also be able to properly fix periodic/channel haste later on. But, for now, I'm removing it entirely so we can rule out those as the cause of problems.
[ view entry ] ( 7 views ) | permalink
"This is your brain" - "This is your brain on core coding". No, I'm not losing it..it was gone a long time ago. Anyway...
-- Ash Realms Pet: --
*Aggro issues at attack with Autoshot
-Added Attackers add at Autoshot toggle. Pet should have access to attacker list now after kicking on autoshot. May, possibly, fix the defensive issue on hunter pets as well.
-- Rogue: --
*Revealing Strike - Currently not increasing the damage of Finishing Strikes on targets afflicted by its debuff
-Added to damage calcs for damaging finishers
*Restless Blades - Currently not allowing damaging finishing moves to reduce the cooldown on Adrenaline Rush, Killing Spree, Redirect and Sprint
-Added combo point counter system into Spell class and added calculations at end cast to reduce timers.
*Deadly Momentum - Attacks made while under its effect currently do not consume its buff.
-Added check to end cast on non-passive, non-triggered, negative spells that can crit. I believe that's all the checks this whore of a spell needs. It's like 4 lines long =P
*Shadowstep when used in a party/raid is putting you behind a party member not your target as it should.
-Umm, this spell uses 'GetSelectedUnit' to get a target to teleport to. GetSelectedUnit is the player's current target. It really can't teleport anywhere else that I can see. I put a return on failure to get a target just to be sure.
*Executioner - Currently not increasing the damage of Rupture, Eviscerate and Deadly Throw
-Added after mods. Not sure if it should be before, after, or with other mods. (i.e. 10% of 10% of 100 is not the same as 20% of 100)
*Eviscerate - Currently only scaling at 30% of Attack Power instead of 45.5%
-It's actually supposed to be a base of 177 to 536 per combo point with an AP bonus of 9.1% per Combo point (45.5% at 5 CP). Which it now will be.
*Murderous Intent - Currently not refunding 30 Energy upon successful Backstab hit on targets with 35% health or less.
-Added proc event for energy regain spell
*Venomous Wounds - The Venomous Wound proc currently doesn't scale with Attack Power
-Yes..it does. Has a base of 8 * level damage and 15% AP bonus. I already remember fixing and testing this on the test server.
*Overkill - Currently granting its buff but not increasing energy regeneration. The Overkill buff is also lasting indefinitely until manually cancelled.
-This used to have a secondary spell with a duration it switched to when the stealth wore off. No longer in the dbc. So, I tried setting a duration to the unlimited aura when you come out of stealth. Added aura check and bonus calc to Regenerate.
*Ambush - Currently not dealing bonus damage with Daggers
-Added dagger bonus to calcs
-- Still going on rogue. Need a break for a bit..hand hurts.
[ view entry ] ( 12 views ) | permalink
-- Priest: --
*Penance - the last tick of penance is still getting clipped with haste, Idk about other channeled spells.
-Haste on periodic effects was removed. Pretty sure the problem is the periodic reduction issue and penance is reducing below zero, causing it to not tick.
*Wait, how is atonement working as intended? Is that the only way you can get it to work? :(
-There is nothing in the spell description about hitting the lowest HP target. In fact, it says it only WORKS on LOW hp targets. But, I removed that part of it against my better judgment.
*Divine Aegis - Still not letting critical heals add a shield absorbing an amount equal to 30% of the heal, nor is it allowing regular prayer of healing heals to proc the effect, but prayer of healing criticals are procing it correctly.
-Damn it, typo.
*Power Word: Shield - Not scaling with spellpower or mastery for disc.
-This section still had the old old formula - updated it. I definitely had the scaling for Shield Discipline in there though. Probably was being affected by the old formula.
*Grace - Only the first tick of penance is applying this effect.
-Was under the impression that it was supposed to proc on apply not tick. I did find info that says it's on tick so I added it to tick.
*Lightwell - Is supposed to scale with 106% of the priest's spellpower, and it currently is not. Also it still spawns with 42 hp and is attackable by the other faction when in the same group as them.
-106% is not the proper scaling. I did, however, add the proper scaling now. Erm...I'll have to get back to you on the attackable problem.
-- Paladin --
*Hammer of the Righteous Attack Power coefficient for its Holy Damage aspect (18% AP)
-Added to core.
*Can't have more than 1 buff even from 2 pallies, if Pally A buffs Kings then Pally B buffs Might.. Kings gets replaced with Might and the other way around too
-Added same caster exclusion check. Means it will stack if not the same caster. Otherwise, it will replace.
*Blessing of Might/Kings - Currently applying two identical buffs when cast on self
- added Return after cast so it doesn't proc the secondary
[ view entry ] | permalink
[ view entry ] ( 3 views ) | permalink
*PW:S and Slow for Spirit pets not displaying correctly
-Changed to more reliable spell versions. Spells changed in the last DBC update.
-- Hunter Pets: --
*Get stuck in combat after fight
-Added same combat clearing function that cage pets use.
*Autoshot - Currently deactivates when moving
-Added attempted fix to this problem
-- Druid: --
*Euphoria - Currently granting Solar Energy instead of Mana when reaching an Eclipse
-Had wrong spell ID in proc..fixed.
-- Paladin: --
*Sanctified Wrath - Currently allowing the use of Hammer of Wrath even when Avenging Wrath is not active (And even when the target is above 20% health)
-Added flag check for health vs avenging w/ talent. May still be active but should fail cast if requirements not met.
*Grand Crusader doesn't generate a charge of Holy Power when used within 6 seconds
-Added end cast check for aura remove and power gain
*Holy Wrath - Currently still stunning all target types instead of just Undead and Demons
-Added my 4th attempt to fix this thing. Can't do much more than whats there now..no type masks or anything. Simply says 'if not demon and not undead - return'.
*Repentance - Currently still having its effect broken by Censure ticks
-Thought for sure I wouldn't attempt this one again..but I got there and figured what the hell.
*Touched by the Light - Currently does not proc the 15% bonus to stamina or 8% Bonus to Spell hit, However, the spell power +60% of Strength does appear to be procing.
-The 15% stamina and 8% SP are a basic aura mod used by thousands of spells. Pretty sure it works fine and is just not updating client side properly. Put in an update flag - should help
*Consecration - Currently not dealing damage to enemies within its area of effect, and not spawning its ground effect
-Removed the NPC summon aura apply and swapped for the NPC method but with the coefficients of the player. May not look proper but should deal the proper damage.
*Seal of Justice - Seal of Justice can currently be stacked with any other Seal (Thus having two seals active at the same time)
-Added Justice to the seal check
*Blessing of Kings/Might - Both blessings currently cannot be cast on other players, and both blessings can currently be active on the Paladin at the same time.
-Added same method as Arcane Brilliance and Power Word: Fort - Target self = single - Target raid member = raid wide buff. Also, added stack rule checks.
* Rebuke - Currently not recognized as learned in the Spellbook even after purchasing it from the class trainer
-I'm going to call bullshit on this one..in that it's not even ON any trainers currently. Asking Ash to add it to the trainers now. Derp.
*Acts of Sacrifice - Currently not allowing Cleanse to remove one snare effect when cast on self
*Hammer of Righteousness (Holy Damage) - Currently not scaling with Attack Power
- I'm assuming this means Hammer of the Righteous - Added AP scaling but I have no real data on the scaling numbers. Put in the standard 14AP = 1Dmg which is what base attacks use.
*Seal of Justice/Hammer of Justice - Casting Hammer of Justice on a player target who is already affected by the Seal of Justice debuff causes him/her to become stuck in place and unable to move or use abilities even after the debuff has expired or is cancelled/dispelled (attempting to use an ability brings up the "you cannot do that while stunned" error)
-I'm fairly baffled on what would cause this. But, I set it to remove Seal of Justice on a target before it applies Hammer of Justice stun. Might have something to do with the runspeed vs stun getting 'stuck' in place.
*Judgement of Insight - Judging Seal of Insight currently deals no damage
-Added Seal triggers to Seals that don't have an aura effect 2 or a default aura type. Generally, these use spell 54158 which scales with AP/SP etc.
-- Priest: --
*Phantasm - Not allowing fade to remove all movement impairing effects.
-Added trigger to end cast
*Vampiric Touch - Casting Mind Blast on a target afflicted by Vampiric Touch currently does not proc Replenishment
-Added replenishment proc
[ view entry ] | permalink
I scrapped the aura idea as it was causing some major issues in the core. It doesn't like those pet auras for some reason. I did, however, massively clean up the stats system. I may have forgot to put back in one or two things during the cleanup..so be sure to report that.
I also went through and verified/fixed all the stat mods from players to pets. Some of these (like Expertise) are calculated server side but will not show client side.
Includes fixes for:
-- Hunter --
* Pets get 100% Expertise, Haste, and Hit rating from masters. Hit will always be what owners hit % is. Expertise is calculated onto the dodge/parry checks like player Expertise only using the owner's Expertise Rating (and any Expertise Auras it has, of course). Haste is calculated in to swing timers at apply of CR Haste to player (Equip item, buff, log in, etc).
* Attack Power now verified at 42.5% contribution to pet
* Attack Power also adds 12.5% to Spell Damage
As far as ability scaling with RAP, that should also be working now as well.
*Haste Mods are now calculated into swing time instead of base damage. Had to remove that antiquated system from devs and replace it.
I basically stripped the entire Pet Stats system down to nothing and rebuilt it from scratch. So, expect some issues that need reporting. Please don't report tooltip/pet sheet problems. Verify that it is not actually working and just not displaying before report. Thanks.
P.S. These updates will go on KA after next restart.
-- Other Fixes (Not compiled yet): --
- Camouflage should no longer get you stuck or pet stuck in either mode.
- Fixed Penance/Grace and Divine Aegis
- Euphoria double mana and mana regain
- Moonfire cast issue
- Thrash, Berserk, and Swipe
[ view entry ] ( 2 views ) | permalink