DA back up and..I scrapped the aura idea as it was causing some major issues in the core. It doesn't like those pet auras for some reason. I did, however, massively clean up the stats system. I may have forgot to put back in one or two things during the cleanup..so be sure to report that.
I also went through and verified/fixed all the stat mods from players to pets. Some of these (like Expertise) are calculated server side but will not show client side.
Includes fixes for:
-- Hunter --
* Pets get 100% Expertise, Haste, and Hit rating from masters. Hit will always be what owners hit % is. Expertise is calculated onto the dodge/parry checks like player Expertise only using the owner's Expertise Rating (and any Expertise Auras it has, of course). Haste is calculated in to swing timers at apply of CR Haste to player (Equip item, buff, log in, etc).
* Attack Power now verified at 42.5% contribution to pet
* Attack Power also adds 12.5% to Spell Damage
As far as ability scaling with RAP, that should also be working now as well.
*Haste Mods are now calculated into swing time instead of base damage. Had to remove that antiquated system from devs and replace it.
I basically stripped the entire Pet Stats system down to nothing and rebuilt it from scratch. So, expect some issues that need reporting. Please don't report tooltip/pet sheet problems. Verify that it is not actually working and just not displaying before report. Thanks.
P.S. These updates will go on KA after next restart.
-- Other Fixes (Not compiled yet): --
- Camouflage should no longer get you stuck or pet stuck in either mode.
- Fixed Penance/Grace and Divine Aegis
- Euphoria double mana and mana regain
- Moonfire cast issue
- Thrash, Berserk, and Swipe
[ view entry ] ( 2 views ) | permalink
Dark Ash's box is having software problems. Might be intermittent for the next while. I will keep people posted.
[ view entry ] | permalink
I hate writing subject text. Anyway, here's some more fixes.
--- Druid: ---
*Moonfire - Currently triggering the global cooldown, but giving the caster a "Spell is not ready yet" error when cast under the effects of a Solar Eclipse (When talented into Sunfire)
-I think it was due to the trigger flag not being set.
*Euphoria - Currently still not granting either of its effects
-Had the wrong icon id set for the dummy aura check
*Thrash - Currently not dealing damage to its primary target, and not applying its Bleed to targets within an 8 yard radius
-Added damage coeffients. This is a fairly basic spell (school damage and periodic damage). It had no damage set..so I imagine that was the problem.
*Berserk - Not giving a 50% chance to refresh the cooldown of your Mangle (Bear) ability
-Added effect to Lacerate's tigger
*Swipe (Bear Form) - Sound but no effect
- Again a basic schooldmg effect. Wondering if the reporter might have an item bug...but I did add the coefficient calculations
-- Hunter: --
*Bestial Wrath / Beast Within - Not removing CC effects
- Added flag check for dispel on apply
*Autoshot - Currently deactivates when moving
-Attempted fix but it's very difficult in this current core
*Kill Command / Claw / Bite - Not calculating RAP
-Adjusted RAP formulas and changed order to prevent conflict. Added debug logs in case this doesn't work (Again)
*Explosive Shot - Incorrect coefficient
-I noticed when Riviera mentioned that the coefficient was 7.7% that it was actually set for 7.7% (Because it divides the base coefficient by the number of ticks), not supposed to do that on Explosive Shot apparently..so I fixed it.
*Critical Strike Rating - Pets currently do not scale with their Master's Critical Strike Rating
-Will scale internally with Hunters. May not display at all or correctly.
----
Huh, I just found all the pet auras to force scaling at proper amounts. I will need to look into using those. I might be able to fix scaling for all the pets if I can code them properly. Taking a break to research this more.
[ view entry ] ( 2 views ) | permalink
-- Shaman: --
*Rockbiter, Windfury, Frostbrand Weapon - Currently not proccing at all or incorrectly or not applying buff
-Tried to clean up and remove legacy code from the procs and core code
*Frozen Power is not rooting targets when frost shock is cast on the at 15 yards+
-Think the issue was in the method checks. Updated.
--- Hunter: ---
Camouflage - works on the pet now. (Thx) but ONLY on the pet, but when your pet is not summoned, it works on the hunter
- I did NOT change the effect that is applied to yourself or any part of the Camouflage effect anywhere in the core. I only set the pet to check if you're camouflaged then camouflage itself as well. This cannot be a correct report.
Wild Quiver (Marksmanship Mastery) - It still double procs, but it doesn't go over a double proc AFAIK.
-It's not a 'double proc' it is checking the aura twice and it's not 'still happening' it was never fixed. It is now.
*Pet standard attack scaling (Claw, Bite, etc)
-Updated to formula from wowhead
--- Priest: ---
*Shadow Orbs - Currently only increasing Periodic Shadow Damage by 10% regardless of the number of Orbs consumed by Mind Blast or Mind Spike (Baseline 22% per Orb)
-According to the design of this spell and all other related spells, when the orbs are consumed, they increase the damage of Mind Blast or Mind Spike at cast..increased by mastery and per orb. Then it applies a buff of 10% damage increase per Orb. This is what it was doing..minus the 10% per orb. Which is now fixed.
*SWD + Maso
-Updated SWD and Maso procs
--- Mastery: ---
*Mastery Gems and Enchants do not add Mastery Rating
-Added CR Mastery calculations into enchant/gem function
--- Druid: ---
*Lifebloom - error proc
- Attempted cleanup of core calculations..even though it should not be possible anyway.
-- Rogue: --
* Slice and Dice with mastery
- Fixed aura proc issue.
More to come.
[ view entry ] | permalink
Fixed and confirmed the fix for both crash issues. Should be good to go now on KA. DA has not reloaded since the fix so it will still have problems until next restart.
Edit: Updates are now on DA. DA still has stability issues..but that's more of a Windows compat problem than anything related to the updates. I won't be able to fix it until I figure out how to get debug mode to run properly with our restarter on there. God, I hate windows...the linux machine is so much easier to get running properly. Just a lot harder to implement changes on.
[ view entry ] ( 10 views ) | permalink
New build is taking forever to compile...sorry for the downtime.
Server went down while I was in the middle of building..that's why it's unstable for the next few minutes.
P.S. F-You server. You WILL work correctly.
[ view entry ] ( 1 view ) | permalink
--- Shaman: ---
*Glyph of the Arctic Wolf - Dosnt effect the ghost wolf transformation
-Unknown model id for the color shift change. Used model for Spirit Wolf as per suggestion on Bug Tracker for now.
--- Hunter: ---
*Camouflage - Currently breaks upon laying of traps, and doesn't camouflage your active pet
-Added trigger for pets and break on self if broke on pet..cannot fix the break part as there's currently no core support.
*Focus Fire does not raise the hunter's ranged haste nor restore any of the hunter pet's focus while in effect.
-This is a basic 3% gain aura..it cannot -not- work without all other haste auras being broken. I did, however, recode it to include the frenzy stack removal and bonus for the haste and pet focus. Added Frenzy trigger spells at pet basic damage as well per Frenzy's description.
*Call Pet - removes from action bar at login
-This is only true if you hotkey the base spell instead of the individual calls inside it. The base spell is coded client-side to not be able to be hotkeyed. Either retail uses some unknown method or they don't allow it to work..either way..we can't do anything about that.
*Chimera Shot, Black Arrow, and Explosive Shot - Currently not including its Ranged Attack Power coefficient in damage calculations.
- Added RAP coefficients
*Cobra Shot - If two hunters have serpent sting up, Cobra shot will only extend the duration of serpent sting for the other hunter's serpent sting
-Updated refresh on Chimera and Duration increase on Serpent Sting to check by caster GUID. Should only increase YOUR Serpent Sting now.
*Aimed Shot - Currently has a 3-second baseline cast time instead of 2.4 seconds
-Cast times are controlled by retail DBC files not us..but I put in a manual edit for this spell. I wager this was not 2.4secs in 4.0 and was only modified later. Oh well, doesn't hurt to manually set it to 2.4 for now. Please keep in mind autoshot adds a 0.5secs delay to cast times.
*Hunters Mark: No effect
-I see no issue with this spell or it's effects in the DBC, the DB, or the core. It's aura is coded correctly and sets the proper flags to mark enemies as tracked. If it's just visually not showing up..not sure what to tell you about that one. The auras are working properly server-side.
*Glyph of Kill Shot - Currently not resetting the cooldown of Kill Shot if it fails to kill the target.
-Added triggered effect and internal cooldown
*Kill command - Does nothing, even when the pet is in proper range of the boss.
-Added trigger and damage calcs
*Intimidation - Not increasing threat
-'Effect: Add Threat' is a basic function...either no threat producing effects are working or the pet one is.
*Growl ability is not creating the proper amount of threat.
-For lack of better values currently, Threat effects for hunter pets now use a RAP * 0.523 coefficient to increase their threat production.
*Serpent's Swiftness - Currently not increasing pet attack speed
-Implemented aura type 342 which appears to be a pet-only attack speed pct increase. Please keep in mind pet attack speed bonuses affect DPS directly NOT their actual time between swings.
*Basic Attacks - Currently not scaling with the Hunter's Ranged Attack Power
-Base white damage is current 1dps per 14ap and AP is increased by 42.5% of owner. So, scaling DOES work.
*Haste - Pets currently do not scale with their master's Haste
-Added min/max damage modifier based on owner's cr haste. Won't increase their attack speed..but rather their damage per second (cr_haste_melee).
*Hit - Pets currently do not scale with their master's Hit
-Added scaling to owner's hit rating when hit rating changes (cr_hit_melee/range/spell).
Not sure what to do with the Expertise..since there isn't any expertise or actual hit rating variable for Pets at all. May need to go back later and create them manually.
--- Rogue: ---
*Executioner - applying haste bonus for slice and dice to all haste effects
-Put flag check in for only Slice and Dice
--- More to come ---
[ view entry ] | permalink
Disabled comments. Might turn them back on later but right now, they're a useless distraction. This site was built as a way to communicate what is being worked on...not have a debate on how it is being done.
Back to work for me.
Edit: Be happy that things are getting worked on..not that things aren't getting worked on the way you want them to.
[ view entry ] ( 3 views ) | permalink
Note: NONE of these changes are LIVE yet so, please stop making reports about the issues listed here as 'still not working'. They won't work until the next build.
--- Druid: ---
*Nature's Bounty - Currently not reducing the cast time of Nourish when Rejuvenation is active on 3 or more targets
-Added a Rejuv counter to player class and modified it to trigger time reduction spell on count 3 or higher and remove on 2 or lower. Don't know if the actual buff spell works (96206)
*Starsurge - Currently not granting either Solar or Lunar Energy
-If Eclipse power > 0 (Solar) then it adds solar, else if less than 0 it adds lunar. I'd think at 0 it would not have a benefit according to the description. So, that's how I coded it.
*Stampede - ravage disappears off your action bar.
-Spell replacement effects like 81022 (Aura type 332) do not work in the core yet. I replaced the aura effect with the triggered damage spell instead (81170). So, it should be like immediately using the effect after the Charge.
*Skull bash - Charge sound is played, but there is no effect (interruption of casting).
-Added proc spells to the dummy effect and also implemented Brutal Impact's portion (5/10% mana increase on Skull Bash's target)
*Mark of the Wild - currently it only buffs the caster
-Now, if targeting self..it will buff self-only. If targeting raid/party member, it will cast aoe buff. This is how Power Word: Fort and Arcane Brilliance are coded so I followed suit.
*Feral Aggression - Not giving Faerie Fire the ability to apply 2/3 stacks
-Spell is set strange..but I did what the retail devs designed. It will retrigger itself X times increasing the stack count.
*Leader Of The Pack - not giving extra crit, or proccing heals on crits. no aura appearing either
-Added AoE buff to shapeshift boosts and the (now two) proc spells for mana and health on melee crit. Unsure if it was all melee attacks or just white on crit..so I set it for all melee attacks on crit
*Primal Madness - not increasing max energy when using Tiger's Fury
-Added max energy proc to Tiger's Fury and Berserk for duration
*Thrash - No effect
- I do not understand how this could have 'no effect'. It is a basic physical damage and periodic tick effect that hundreds of spells use. I did, however, see that it's coefficients were not in the DB and added them
*Lacerate - incorrect damage
-Did not have base coefficient - added it and changed the dot coefficient to it's proper value
*Euphoria - Currently not granting Wrath or Starfire a chance to double their energy gains when cast outside of an Eclipse state, and not granting mana when an Eclipse state is reached
-Added both effects
*Sunfire - Currently not replacing Moonfire with the Sunfire spell when in a Solar Eclipse state
-Core does not currently have the ability to replace spells in book/bar on the fly. But, if you cast Moonfire with this talent and in Solar, it will switch out the spells during cast
*Leather Specialization - Not learning from book
-Implemented Armor Specialization aura type in core - Ash will need to update the trainers with the appropriate spells (Only coded Leather Druid/Rogue so far)
*Bear Form- Not switching from 65% to 120% after lv39.
-Modified at apply
--- Priest: ---
*Archangel - Currently giving the caster a "you can't do that yet" error when attempting a cast
-Added a trigger aura that I believe is the cause of this error
*Evangelism - Currently proccing off any damage dealt instead of just Smite, Holy Fire and Mindflay
-Added more proc flag checking
*Chakra - Currently not proccing Chakra: Serenity, Chakra: Chastise or Chakra: Sanctuary when their related spells are cast while under its effect
-Added new trigger method..should work now
*Lightwell - NPC is spawning as hostile
-Set to friend - P.S. this is SUPPOSED to be a NPC..not a GObject. That is per retail not us.
*Shadow Word: Death - Not self-damaging
-Added secondary check for proc effect
*Masochism - Not Granting mana on Shadow Word: Death self-damage
-SWD fix should fix this proc as well
--- Shaman: ---
*Windfury Weapon - Currently not causing Windfury Weapon imbues on two dual-wielded weapons to share the same internal cooldown on their procs
-Added internal cooldown to the proc spell (3secs) which is global for any proc. Should fix the issue
*Mana Tide Totem - Giving incorrect spirit
-Set to 200% instead of 200 now
*Glyph of Healing Stream Totem - Dosnt add the resistance
-Added Effect proc to Totem if have glyph
*Searing Flame Talent in The Enhancement tree is procing from Magma Totem which is stacking 1 searing flame on everything to 5.
-Added flag check for Searing Bolt specifically
*Glyph of Grounding Totem doesn't reflect spells cast back on the caster like it should.
-Added original caster as Magnet target instead of Totem in case of glyph on owner
--- Help needed ----
*Glyph of the Arctic Wolf - Dosnt effect the ghost wolf transformation
- I do not have the new model ID for this effect nor can I find it anywhere...even a NPC with a similar look would do it.
-- Warrior: ---
*Frenzied Regeneration and Glyph - Frenzied adding flat health not percentage and Glyph not removing healing proc
- Fixed both effects
[ view entry ] ( 18 views ) | permalink
Well I inadvertently fixed Thick Hide on bear form while I was working out a Spirit of Redemption problem. So, that will be fixed on next restart.
Also trying to work out the problem with HoT tick degradation. I'm guessing it has something to do with the amplitude system that decreases over all tick time based on haste..which isn't working correctly anyway so I removed it for now. Or well..for next restart.
[ view entry ] ( 7 views ) | permalink
Calendar
